chrome/browser/extensions/extension_popup_apitest.cc - Issue 2868003: ExtensionApiTest.Popup is flaky on windows.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_popup_apitest.cc

Issue 2868003: ExtensionApiTest.Popup is flaky on windows. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "chrome/browser/extensions/extension_apitest.h"	6 #include "chrome/browser/extensions/extension_apitest.h"

7 #include "chrome/common/chrome_switches.h"	7 #include "chrome/common/chrome_switches.h"

8	8

9 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Popup) {	9 // Flaky on windows. http://crbug.com/46601

	10 #if defined(OS_WIN)

	11 #define MAYBE_Popup FLAKY_Popup

	12 #else

	13 #define MAYBE_Popup Popup

	14 #endif

	15

	16 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Popup) {

10 CommandLine::ForCurrentProcess()->AppendSwitch(	17 CommandLine::ForCurrentProcess()->AppendSwitch(

11 switches::kEnableExperimentalExtensionApis);	18 switches::kEnableExperimentalExtensionApis);

12 CommandLine::ForCurrentProcess()->AppendSwitch(	19 CommandLine::ForCurrentProcess()->AppendSwitch(

13 switches::kEnableExtensionToolstrips);	20 switches::kEnableExtensionToolstrips);

14	21

15 ASSERT_TRUE(RunExtensionTest("popup")) << message_;	22 ASSERT_TRUE(RunExtensionTest("popup")) << message_;

16 }	23 }

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »