Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2867047: Bring some OOP and sanity to gclient.py. (Closed)

Created:
10 years, 5 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Bring some OOP and sanity to gclient.py. - Changed the algorithm from breadth-first to depth-first. - Added infinite recursion support. - Fixed From() of From() dependency. - Fixed cross solution custom deps aliasing. - Removed support code for old .gclient_entries format. - Removed IsGitCheckout() in favor for a direct check for .git presence. TEST=all test pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51760

Patch Set 1 #

Patch Set 2 : based off http://codereview.chromium.org/2885021/show to simplify diff #

Patch Set 3 : add back docstring #

Total comments: 2

Patch Set 4 : Reuse old code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -303 lines) Patch
M gclient.py View 1 2 3 12 chunks +214 lines, -290 lines 0 comments Download
M gclient_utils.py View 1 1 chunk +0 lines, -8 lines 0 comments Download
M tests/gclient_smoketest.py View 4 chunks +2 lines, -4 lines 0 comments Download
M tests/gclient_utils_test.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
Dependent on http://codereview.chromium.org/2885021/show The main difference with http://codereview.chromium.org/2627007/show is that gclient revinfo prints out exactly ...
10 years, 5 months ago (2010-07-05 17:37:46 UTC) #1
Mandeep Singh Baines
Just one minor nit. http://codereview.chromium.org/2867047/diff/5001/6001 File gclient.py (right): http://codereview.chromium.org/2867047/diff/5001/6001#newcode366 gclient.py:366: self.file_list[i] = self.file_list[i][1:] Don't you ...
10 years, 5 months ago (2010-07-07 17:00:09 UTC) #2
M-A Ruel
http://codereview.chromium.org/2867047/diff/5001/6001 File gclient.py (right): http://codereview.chromium.org/2867047/diff/5001/6001#newcode366 gclient.py:366: self.file_list[i] = self.file_list[i][1:] On 2010/07/07 17:00:09, Mandeep Singh Baines ...
10 years, 5 months ago (2010-07-07 18:54:33 UTC) #3
Mandeep Singh Baines
10 years, 5 months ago (2010-07-07 19:26:45 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698