Pull new PPAPI to fix the 64-bit Linux build.

Pull new PPAPI to fix the 64-bit Linux build.

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51490

[brettw, 2010-07-02 04:04:54]

TBR.

Please be sure you can roll deps when you check into PPAPI.

[awong, 2010-07-02 16:51:10]

LGTM

Thanks for fixing this.  I actually did test 64-bit linux compilation
locally.  For some reason, this is links w/o -fPIC on my box even though it
shouldn't.  Just reverified that it still links.  Strange.

On Thu, Jul 1, 2010 at 9:04 PM, <brettw@chromium.org> wrote:

> Reviewers: awong,
>
> Message:
> TBR.
>
> Please be sure you can roll deps when you check into PPAPI.
>
> Description:
> Pull new PPAPI to fix the 64-bit Linux build.
>
> TEST=none
> BUG=none
>
> Please review this at http://codereview.chromium.org/2867042/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>
>
> Index: DEPS
> ===================================================================
> --- DEPS        (revision 51489)
> +++ DEPS        (working copy)
> @@ -158,7 +158,7 @@
>     Var("libvpx_revision"),
>
>   "src/third_party/ppapi":
> -    "http://ppapi.googlecode.com/svn/trunk@94",
> +    "http://ppapi.googlecode.com/svn/trunk@96",
>
>   "src/third_party/libjingle/source":
>     "http://libjingle.googlecode.com/svn/branches/nextsnap@" +
>
>
>

[brettw, 2010-07-02 16:55:22]

On Fri, Jul 2, 2010 at 9:50 AM, Albert J. Wong (王重傑)
<ajwong@chromium.org> wrote:
> LGTM
> Thanks for fixing this.  I actually did test 64-bit linux compilation
> locally.  For some reason, this is links w/o -fPIC on my box even though it
> shouldn't.  Just reverified that it still links.  Strange.
> On Thu, Jul 1, 2010 at 9:04 PM, <brettw@chromium.org> wrote:

This only happens in release mode for some reason. I had the same experience.

Brett

[awong, 2010-07-02 17:00:28]

On Fri, Jul 2, 2010 at 9:55 AM, Brett Wilson <brettw@chromium.org> wrote:

> On Fri, Jul 2, 2010 at 9:50 AM, Albert J. Wong (王重傑)
> <ajwong@chromium.org> wrote:
> > LGTM
> > Thanks for fixing this.  I actually did test 64-bit linux compilation
> > locally.  For some reason, this is links w/o -fPIC on my box even though
> it
> > shouldn't.  Just reverified that it still links.  Strange.
> > On Thu, Jul 1, 2010 at 9:04 PM, <brettw@chromium.org> wrote:
>
> This only happens in release mode for some reason. I had the same
> experience.
>

Gotcha.  I just did a quick test.  It seems that we happen to be getting
"lucky" in that  with optimizations disabled (-O0), the generated code
happens to be relocatable. However, if you crank up optimizations, say to
-O2, we start getting textrels so the link stage fails.

Thanks again for cleaning up after me!

-Albert