Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9007)

Unified Diff: chrome/browser/views/location_bar/star_view.cc

Issue 2867037: Don's show star tooltip when BookmarkBubbleView is showing. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/location_bar/star_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/location_bar/star_view.cc
diff --git a/chrome/browser/views/location_bar/star_view.cc b/chrome/browser/views/location_bar/star_view.cc
index c559a27e11d49f97dbc599927955b474adfbb92e..9dfaf621d582bd3bd12c8824e913f8266e10e65e 100644
--- a/chrome/browser/views/location_bar/star_view.cc
+++ b/chrome/browser/views/location_bar/star_view.cc
@@ -9,6 +9,7 @@
#include "chrome/app/chrome_dll_resource.h"
#include "chrome/browser/command_updater.h"
#include "chrome/browser/view_ids.h"
+#include "chrome/browser/views/browser_dialogs.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
@@ -38,6 +39,14 @@ bool StarView::GetAccessibleRole(AccessibilityTypes::Role* role) {
return true;
}
+bool StarView::GetTooltipText(const gfx::Point& p, std::wstring* tooltip) {
+ // Don't show tooltip to distract user if BookmarkBubbleView is showing.
+ if (browser::IsBookmarkBubbleViewShowing())
+ return false;
+
+ return ImageView::GetTooltipText(p, tooltip);
+}
+
bool StarView::OnMousePressed(const views::MouseEvent& event) {
// We want to show the bubble on mouse release; that is the standard behavior
// for buttons.
« no previous file with comments | « chrome/browser/views/location_bar/star_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698