Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2867031: Supports High DPI mode.... (Closed)

Created:
10 years, 5 months ago by Hironori Bono
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Supports High DPI mode. When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later. BUG=1715, 36939 TEST=Run chrome.exe on the screen resolution higher than 120 DPI. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52446

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M app/win_util.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M app/win_util.cc View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/browser_init.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hironori Bono
10 years, 5 months ago (2010-06-29 10:03:54 UTC) #1
Hironori Bono
ping?
10 years, 5 months ago (2010-07-07 08:02:04 UTC) #2
Ben Goodger (Google)
http://codereview.chromium.org/2867031/diff/6001/7001 File app/win_util.cc (right): http://codereview.chromium.org/2867031/diff/6001/7001#newcode588 app/win_util.cc:588: if (win_util::GetWinVersion() < win_util::WINVERSION_VISTA) What if you're using the ...
10 years, 5 months ago (2010-07-07 21:06:54 UTC) #3
Hironori Bono
http://codereview.chromium.org/2867031/diff/6001/7001 File app/win_util.cc (right): http://codereview.chromium.org/2867031/diff/6001/7001#newcode588 app/win_util.cc:588: if (win_util::GetWinVersion() < win_util::WINVERSION_VISTA) On 2010/07/07 21:06:54, Ben Goodger ...
10 years, 5 months ago (2010-07-09 07:58:42 UTC) #4
Ben Goodger (Google)
10 years, 5 months ago (2010-07-09 17:12:14 UTC) #5
Well maybe you should leave it as you had it before... since you say calling
that function is harmless with the non-native frame, I think it's best if we
call it in both modes... since calling ShouldUseVistaFrame implies a bug to
me... since this code only executes once (at browser startup, for the entire
process), what if the display mode changes? That would imply any assumption as
to the presence or absence of the native frame would be invalid. In this case is
harmless but now I understand it better I think your original check was better.
LGTM for that.

Powered by Google App Engine
This is Rietveld 408576698