net/base/x509_certificate_mac.cc - Issue 2867026: Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than assume ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate_mac.cc

Issue 2867026: Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than assume ownership (Closed)

Patch Set: Deleted one comment too many Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_certificate_mac.cc

diff --git a/net/base/x509_certificate_mac.cc b/net/base/x509_certificate_mac.cc

index 25e2104be54641375e43a4cd8808498b08924b92..8d7970ae001eaf1ce654869817718e36bba84271 100644

--- a/net/base/x509_certificate_mac.cc

+++ b/net/base/x509_certificate_mac.cc

@@ -735,7 +735,6 @@ bool X509Certificate::IsIssuedBy(

for (int i = 0; i < n; ++i) {

SecCertificateRef cert_handle = reinterpret_cast<SecCertificateRef>(

const_cast<void*>(CFArrayGetValueAtIndex(cert_chain, i)));

- CFRetain(cert_handle);

scoped_refptr<X509Certificate> cert = X509Certificate::CreateFromHandle(

cert_handle,

X509Certificate::SOURCE_LONE_CERT_IMPORT,

@@ -795,6 +794,7 @@ bool X509Certificate::GetSSLClientCertificates (

err = SecIdentityCopyCertificate(identity, &cert_handle);

if (err != noErr)

continue;

+ scoped_cftyperef<SecCertificateRef> scoped_cert_handle(cert_handle);

scoped_refptr<X509Certificate> cert(

CreateFromHandle(cert_handle, SOURCE_LONE_CERT_IMPORT,

« no previous file with comments | « net/base/x509_certificate.cc ('k') | net/base/x509_certificate_unittest.cc » ('j') | no next file with comments »