chrome/browser/ssl/ssl_client_auth_handler_win.cc - Issue 2867026: Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than assume ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_client_auth_handler_win.cc

Issue 2867026: Make X509Certificate::CreateFromHandle() copy the OSCertHandle, rather than assume ownership (Closed)

Patch Set: Deleted one comment too many Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_client_auth_handler_win.cc

diff --git a/chrome/browser/ssl/ssl_client_auth_handler_win.cc b/chrome/browser/ssl/ssl_client_auth_handler_win.cc

index 8c7bc4244fdbced62b79056e6ab6b6560818effc..cbac1aed902359dc37c4b1ba867c3401c48264a9 100644

--- a/chrome/browser/ssl/ssl_client_auth_handler_win.cc

+++ b/chrome/browser/ssl/ssl_client_auth_handler_win.cc

@@ -48,6 +48,7 @@ void SSLClientAuthHandler::DoSelectCertificate() {

cert_context,

net::X509Certificate::SOURCE_LONE_CERT_IMPORT,

net::X509Certificate::OSCertHandles());

+ net::X509Certificate::FreeOSCertHandle(cert_context);

}

ok = CertCloseStore(client_certs, CERT_CLOSE_STORE_CHECK_FLAG);

« no previous file with comments | « no previous file | net/base/cert_test_util.cc » ('j') | no next file with comments »