Issue 2867009: Add const to two methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2867009: Add const to two methods. (Closed)

Created:
10 years, 6 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add const to two methods. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50111

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	gfx/point.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

10 years, 6 months ago (2010-06-17 06:32:08 UTC) #2

LGTM

On Wed, Jun 16, 2010 at 11:20 PM,  <jam@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Add const to two methods.
>
> Please review this at http://codereview.chromium.org/2867009/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     gfx/point.h
>
>
> Index: gfx/point.h
> ===================================================================
> --- gfx/point.h (revision 49830)
> +++ gfx/point.h (working copy)
> @@ -52,13 +52,13 @@
>     y_ += delta_y;
>   }
>
> -  Point Add(const Point& other) {
> +  Point Add(const Point& other) const{
>     Point copy = *this;
>     copy.Offset(other.x_, other.y_);
>     return copy;
>   }
>
> -  Point Subtract(const Point& other) {
> +  Point Subtract(const Point& other) const {
>     Point copy = *this;
>     copy.Offset(-other.x_, -other.y_);
>     return copy;
>
>
>

Expand Messages | Collapse Messages