Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: chrome/common/extensions/extension_resource_unittest.cc

Issue 2867008: Show extension icons next to their top-level context menu items.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_resource.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_resource_unittest.cc
===================================================================
--- chrome/common/extensions/extension_resource_unittest.cc (revision 50770)
+++ chrome/common/extensions/extension_resource_unittest.cc (working copy)
@@ -33,7 +33,9 @@
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &root_path));
FilePath relative_path;
relative_path = relative_path.AppendASCII("cira.js");
- ExtensionResource resource(root_path, relative_path);
+ std::string extension_id;
+ Extension::GenerateId("test", &extension_id);
+ ExtensionResource resource(extension_id, root_path, relative_path);
// The path doesn't exist on disk, we will be returned an empty path.
EXPECT_EQ(root_path.value(), resource.extension_root().value());
@@ -68,7 +70,10 @@
}
FilePath path;
- ExtensionResource resource(temp.path(), FilePath().AppendASCII(filename));
+ std::string extension_id;
+ Extension::GenerateId("test", &extension_id);
+ ExtensionResource resource(extension_id, temp.path(),
+ FilePath().AppendASCII(filename));
FilePath resolved_path = resource.GetFilePath();
FilePath expected_path;
« no previous file with comments | « chrome/common/extensions/extension_resource.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698