Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Side by Side Diff: chrome/browser/browser_list_gtk.cc

Issue 2866034: Refactor shutdown code to allow win/linux to run after last browser closes. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Uploaded patch that resolves merge issue Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/browser_list.cc ('k') | chrome/browser/browser_list_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser_list.h" 5 #include "chrome/browser/browser_list.h"
6 6
7 #include <gtk/gtk.h> 7 #include <gtk/gtk.h>
8 8
9 // static 9 // static
10 void BrowserList::AllBrowsersClosed() { 10 void BrowserList::AllBrowsersClosedAndAppExiting() {
11 // Close non-browser windows. 11 // Close non-browser windows.
12 GList* window_list = gtk_window_list_toplevels(); 12 GList* window_list = gtk_window_list_toplevels();
13 g_list_foreach(window_list, (GFunc)g_object_ref, NULL); 13 g_list_foreach(window_list, (GFunc)g_object_ref, NULL);
14 for (GList* i = window_list; i != NULL; i = g_list_next(i)) { 14 for (GList* i = window_list; i != NULL; i = g_list_next(i)) {
15 GtkWindow* window = GTK_WINDOW(i->data); 15 GtkWindow* window = GTK_WINDOW(i->data);
16 // We filter by visible widgets because there are toplevel windows that if 16 // We filter by visible widgets because there are toplevel windows that if
17 // we try to destroy, we crash. For example, trying to destroy the tooltip 17 // we try to destroy, we crash. For example, trying to destroy the tooltip
18 // window or the toplevel associated with drop down windows crashes. 18 // window or the toplevel associated with drop down windows crashes.
19 // We further filter to only close dialogs, as blindly closing all windows 19 // We further filter to only close dialogs, as blindly closing all windows
20 // causes problems with things like status icons. 20 // causes problems with things like status icons.
21 if (GTK_WIDGET_VISIBLE(GTK_WIDGET(window)) && 21 if (GTK_WIDGET_VISIBLE(GTK_WIDGET(window)) &&
22 (GTK_IS_DIALOG(GTK_WIDGET(window)))) 22 (GTK_IS_DIALOG(GTK_WIDGET(window))))
23 gtk_widget_destroy(GTK_WIDGET(window)); 23 gtk_widget_destroy(GTK_WIDGET(window));
24 } 24 }
25 g_list_foreach(window_list, (GFunc)g_object_unref, NULL); 25 g_list_foreach(window_list, (GFunc)g_object_unref, NULL);
26 g_list_free(window_list); 26 g_list_free(window_list);
27 } 27 }
OLDNEW
« no previous file with comments | « chrome/browser/browser_list.cc ('k') | chrome/browser/browser_list_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698