Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2866026: Rename Dns prefetching files to Predictor files... (Closed)

Created:
10 years, 6 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews, jam+cc_chromium.org, cbentzel+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Rename Dns prefetching files to Predictor files We are now doing more than DNS pre-resolution, and want to do TCP/IP pre-warming. This change uses the updated class names etc., and tries to use Predictor as the common element in most names. r=mbelshe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50951

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -4091 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_init.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_main.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_prefs.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/advanced_contents_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/connect_interceptor.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/net/dns_global.h View 1 2 3 4 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/net/dns_global.cc View 1 2 3 4 1 chunk +0 lines, -756 lines 0 comments Download
D chrome/browser/net/dns_host_info.h View 1 2 3 4 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/net/dns_host_info.cc View 1 2 3 4 1 chunk +0 lines, -439 lines 0 comments Download
D chrome/browser/net/dns_host_info_unittest.cc View 1 2 3 4 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/browser/net/dns_master.h View 1 2 3 4 1 chunk +0 lines, -267 lines 0 comments Download
D chrome/browser/net/dns_master.cc View 1 2 3 4 1 chunk +0 lines, -643 lines 0 comments Download
D chrome/browser/net/dns_master_unittest.cc View 1 2 3 4 1 chunk +0 lines, -640 lines 0 comments Download
A + chrome/browser/net/predictor.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/net/predictor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/net/predictor_api.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/net/predictor_api.cc View 1 2 3 4 5 6 7 8 9 5 chunks +8 lines, -3 lines 0 comments Download
A + chrome/browser/net/predictor_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/net/url_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/net/url_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/net/url_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/advanced_contents_view.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/common/net/dns.h View 1 2 3 4 1 chunk +0 lines, -29 lines 0 comments Download
A + chrome/common/net/predictor_common.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/renderer/net/predictor_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/renderer/net/predictor_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/renderer/net/predictor_queue_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/renderer/net/render_dns_master.h View 1 2 3 4 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/renderer/net/render_dns_master.cc View 1 2 3 4 1 chunk +0 lines, -162 lines 0 comments Download
D chrome/renderer/net/render_dns_master_unittest.cc View 1 2 3 4 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/renderer/net/render_dns_queue.h View 1 2 3 4 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/renderer/net/render_dns_queue.cc View 1 2 3 4 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/renderer/net/render_dns_queue_unittest.cc View 1 2 3 4 1 chunk +0 lines, -262 lines 0 comments Download
A + chrome/renderer/net/renderer_net_predictor.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/renderer/net/renderer_net_predictor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/renderer/net/renderer_predictor_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_webkitclient_impl.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jar (doing other things)
Other than the file renaming, and #include line changing, there should be almost no code ...
10 years, 6 months ago (2010-06-25 22:16:09 UTC) #1
Mike Belshe
When the bbots pass, LGTM!
10 years, 6 months ago (2010-06-25 22:49:22 UTC) #2
Mike Belshe
Don't forget the newlines on the ends of the new files that don't have them.
10 years, 6 months ago (2010-06-25 22:49:56 UTC) #3
jar (doing other things)
10 years, 6 months ago (2010-06-25 23:16:06 UTC) #4
I'm pretty sure this is a bogus complaint (about newlines).  I see it in all
CLs with new files... and since all I did was an svn mv of the old file...
I'm pretty sure the newline in there in each.

I manually checked on a few files, and they all had terminal newlines.

Jim

On Fri, Jun 25, 2010 at 3:49 PM, <mbelshe@chromium.org> wrote:

> Don't forget the newlines on the ends of the new files that don't have
> them.
>
>
>
> http://codereview.chromium.org/2866026/show
>

Powered by Google App Engine
This is Rietveld 408576698