Linux: delete the unencrypted login database file after a successful password migration.

chrome/browser/password_manager/password_store_x_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/scoped_temp_dir.h"
 #include "base/stl_util-inl.h"
 #include "base/string_util.h"
 #include "base/time.h"
 #include "base/waitable_event.h"
 #include "chrome/browser/password_manager/password_form_data.h"
 #include "chrome/browser/password_manager/password_store_change.h"
 #include "chrome/browser/password_manager/password_store_x.h"
 #include "chrome/browser/webdata/web_data_service.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/testing_profile.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::WaitableEvent;
 using testing::_;
 using testing::DoAll;
 using testing::ElementsAreArray;
 using testing::Pointee;
 using testing::Property;
 using testing::WithArg;
 using webkit_glue::PasswordForm;
 
+typedef std::vector<PasswordForm*> VectorOfForms;
+
 namespace {
 
 class MockPasswordStoreConsumer : public PasswordStoreConsumer {
  public:
   MOCK_METHOD2(OnPasswordStoreRequestDone,
                void(int, const std::vector<PasswordForm*>&));
 };
 
 class MockWebDataServiceConsumer : public WebDataServiceConsumer {
  public:
@@ skipping 196 matching lines @@
       login_db_->GetBlacklistLogins(&forms);
     mock_return_->OnLoginDatabaseQueryDone(forms);
   }
 
  private:
   LoginDatabase* login_db_;
   bool autofillable_;
   MockLoginDatabaseReturn* mock_return_;
 };
 
-const PasswordFormData g_autofillable_data[] = {
-  { PasswordForm::SCHEME_HTML,
-    "http://foo.example.com",
-    "http://foo.example.com/origin",
-    "http://foo.example.com/action",
-    L"submit_element",
-    L"username_element",
-    L"password_element",
-    L"username_value",
-    L"password_value",
-    true, false, 1 },
-  { PasswordForm::SCHEME_HTML,
-    "http://bar.example.com",
-    "http://bar.example.com/origin",
-    "http://bar.example.com/action",
-    L"submit_element",
-    L"username_element",
-    L"password_element",
-    L"username_value",
-    L"password_value",
-    true, false, 2 },
-  { PasswordForm::SCHEME_HTML,
-    "http://baz.example.com",
-    "http://baz.example.com/origin",
-    "http://baz.example.com/action",
-    L"submit_element",
-    L"username_element",
-    L"password_element",
-    L"username_value",
-    L"password_value",
-    true, false, 3 },
-};
-const PasswordFormData g_blacklisted_data[] = {
-  { PasswordForm::SCHEME_HTML,
-    "http://blacklisted.example.com",
-    "http://blacklisted.example.com/origin",
-    "http://blacklisted.example.com/action",
-    L"submit_element",
-    L"username_element",
-    L"password_element",
-    NULL,
-    NULL,
-    false, false, 1 },
-  { PasswordForm::SCHEME_HTML,
-    "http://blacklisted2.example.com",
-    "http://blacklisted2.example.com/origin",
-    "http://blacklisted2.example.com/action",
-    L"submit_element",
-    L"username_element",
-    L"password_element",
-    NULL,
-    NULL,
-    false, false, 2 },
-};
+// Generate |count| expected logins, either autofillable or blacklisted.
+void InitExpectedForms(bool autofillable, size_t count, VectorOfForms* forms) {
+  const char* domain = autofillable ? "example" : "blacklisted";
+  for (size_t i = 0; i < count; ++i) {
+    std::string realm = StringPrintf("http://%zu.%s.com", i, domain);
+    std::string origin = StringPrintf("http://%zu.%s.com/origin", i, domain);
+    std::string action = StringPrintf("http://%zu.%s.com/action", i, domain);
+    PasswordFormData data = {
+      PasswordForm::SCHEME_HTML,
+      realm.c_str(),
+      origin.c_str(),
+      action.c_str(),
+      L"submit_element",
+      L"username_element",
+      L"password_element",
+      autofillable ? L"username_value" : NULL,
+      autofillable ? L"password_value" : NULL,
+      autofillable, false, i + 1 };
+    forms->push_back(CreatePasswordFormFromData(data));
+  }
+}
 
 }  // anonymous namespace
 
-typedef std::vector<PasswordForm*> VectorOfForms;
-
 // LoginDatabase isn't reference counted, but in these unit tests that won't be
 // a problem as it always outlives the threads we post tasks to.
 template<>
 struct RunnableMethodTraits<LoginDatabase> {
   void RetainCallee(LoginDatabase*) {}
   void ReleaseCallee(LoginDatabase*) {}
 };
 
 enum BackendType {
   NO_BACKEND,
   FAILING_BACKEND,
   WORKING_BACKEND
 };
 
 class PasswordStoreXTest : public testing::TestWithParam<BackendType> {
  protected:
   PasswordStoreXTest()
       : ui_thread_(ChromeThread::UI, &message_loop_),
         db_thread_(ChromeThread::DB) {
   }
 
   virtual void SetUp() {
     ASSERT_TRUE(db_thread_.Start());
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
 
     profile_.reset(new TestingProfile());
 
     login_db_.reset(new LoginDatabase());
-    ASSERT_TRUE(login_db_->Init(temp_dir_.path().Append(
-        FILE_PATH_LITERAL("login_test"))));
+    ASSERT_TRUE(login_db_->Init(temp_dir_.path().Append("login_test")));
 
     wds_ = new WebDataService();
     ASSERT_TRUE(wds_->Init(temp_dir_.path()));
   }
 
   virtual void TearDown() {
     wds_->Shutdown();
     MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask);
     MessageLoop::current()->Run();
     db_thread_.Stop();
@@ skipping 29 matching lines @@
   MessageLoop::current()->Quit();
 }
 
 MATCHER(EmptyWDResult, "") {
   return static_cast<const WDResult<std::vector<PasswordForm*> >*>(
       arg)->GetValue().empty();
 }
 
 TEST_P(PasswordStoreXTest, WDSMigration) {
   VectorOfForms expected_autofillable;
-  for (unsigned int i = 0; i < ARRAYSIZE_UNSAFE(g_autofillable_data); ++i) {
-    expected_autofillable.push_back(
-        CreatePasswordFormFromData(g_autofillable_data[i]));
-  }
+  InitExpectedForms(true, 5, &expected_autofillable);
 
   VectorOfForms expected_blacklisted;
-  for (unsigned int i = 0; i < ARRAYSIZE_UNSAFE(g_blacklisted_data); ++i) {
-    expected_blacklisted.push_back(
-        CreatePasswordFormFromData(g_blacklisted_data[i]));
-  }
+  InitExpectedForms(false, 5, &expected_blacklisted);
 
   // Populate the WDS with logins that should be migrated.
   for (VectorOfForms::iterator it = expected_autofillable.begin();
        it != expected_autofillable.end(); ++it) {
     wds_->AddLogin(**it);
   }
   for (VectorOfForms::iterator it = expected_blacklisted.begin();
        it != expected_blacklisted.end(); ++it) {
     wds_->AddLogin(**it);
   }
@@ skipping 231 matching lines @@
   // Deleting the login should trigger a notification.
   store->RemoveLogin(*form);
 
   // Wait for PasswordStore to send the notification.
   ChromeThread::PostTask(ChromeThread::DB, FROM_HERE, new SignalingTask(&done));
   done.Wait();
 }
 
 TEST_P(PasswordStoreXTest, NativeMigration) {
   VectorOfForms expected_autofillable;
-  for (unsigned int i = 0; i < ARRAYSIZE_UNSAFE(g_autofillable_data); ++i) {
-    expected_autofillable.push_back(
-        CreatePasswordFormFromData(g_autofillable_data[i]));
-  }
+  InitExpectedForms(true, 50, &expected_autofillable);
 
   VectorOfForms expected_blacklisted;
-  for (unsigned int i = 0; i < ARRAYSIZE_UNSAFE(g_blacklisted_data); ++i) {
-    expected_blacklisted.push_back(
-        CreatePasswordFormFromData(g_blacklisted_data[i]));
-  }
+  InitExpectedForms(false, 50, &expected_blacklisted);
+
+  // Get the initial size of the login DB file, before we populate it.
+  // This will be used later to make sure it gets back to this size.
+  const FilePath login_db_file = temp_dir_.path().Append("login_test");
+  file_util::FileInfo db_file_start_info;
+  ASSERT_TRUE(file_util::GetFileInfo(login_db_file, &db_file_start_info));
 
   LoginDatabase* login_db = login_db_.get();
 
   // Populate the login DB with logins that should be migrated.
   for (VectorOfForms::iterator it = expected_autofillable.begin();
        it != expected_autofillable.end(); ++it) {
     ChromeThread::PostTask(ChromeThread::DB,
                            FROM_HERE,
                            NewRunnableMethod(login_db,
                                              &LoginDatabase::AddLogin,
                                              **it));
   }
   for (VectorOfForms::iterator it = expected_blacklisted.begin();
        it != expected_blacklisted.end(); ++it) {
     ChromeThread::PostTask(ChromeThread::DB,
                            FROM_HERE,
                            NewRunnableMethod(login_db,
                                              &LoginDatabase::AddLogin,
                                              **it));
   }
 
   // Schedule another task on the DB thread to notify us that it's safe to
   // carry on with the test.
   WaitableEvent done(false, false);
   ChromeThread::PostTask(ChromeThread::DB, FROM_HERE, new SignalingTask(&done));
   done.Wait();
 
+  // Get the new size of the login DB file. We expect it to be larger.
+  file_util::FileInfo db_file_full_info;
+  ASSERT_TRUE(file_util::GetFileInfo(login_db_file, &db_file_full_info));
+  EXPECT_GT(db_file_full_info.size, db_file_start_info.size);
+
   // Pretend that the WDS migration has already taken place.
   profile_->GetPrefs()->RegisterBooleanPref(prefs::kLoginDatabaseMigrated,
                                             true);
 
   // Initializing the PasswordStore shouldn't trigger a native migration (yet).
   scoped_refptr<PasswordStoreX> store(
       new PasswordStoreX(login_db_.release(),
                            profile_.get(),
                            wds_.get(),
                            GetBackend()));
@@ skipping 57 matching lines @@
         .WillOnce(WithArg<0>(STLDeleteElements0()));
   }
 
   ChromeThread::PostTask(ChromeThread::DB, FROM_HERE,
       new LoginDatabaseQueryTask(login_db, false, &ld_return));
 
   // Wait for the login DB methods to execute on the DB thread.
   ChromeThread::PostTask(ChromeThread::DB, FROM_HERE, new SignalingTask(&done));
   done.Wait();
 
+  if (GetParam() == WORKING_BACKEND) {
+    // If the migration succeeded, then not only should there be no logins left
+    // in the login DB, but also the file should have been deleted and then
+    // recreated. We approximate checking for this by checking that the file
+    // size is equal to the size before we populated it, even though it was
+    // larger after populating it.
+    file_util::FileInfo db_file_end_info;
+    ASSERT_TRUE(file_util::GetFileInfo(login_db_file, &db_file_end_info));
+    EXPECT_EQ(db_file_start_info.size, db_file_end_info.size);
+  }
+
   STLDeleteElements(&expected_autofillable);
   STLDeleteElements(&expected_blacklisted);
 }
 
 INSTANTIATE_TEST_CASE_P(NoBackend,
                         PasswordStoreXTest,
                         testing::Values(NO_BACKEND));
 INSTANTIATE_TEST_CASE_P(FailingBackend,
                         PasswordStoreXTest,
                         testing::Values(FAILING_BACKEND));
 INSTANTIATE_TEST_CASE_P(WorkingBackend,
                         PasswordStoreXTest,
                         testing::Values(WORKING_BACKEND));