Issue 2866019: [gcc] Kill NACL_LEA_MATCH_ADDRESS_OPERAND and insn_is_nacl_lea.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2866019: [gcc] Kill NACL_LEA_MATCH_ADDRESS_OPERAND and insn_is_nacl_lea. (Closed)

Created:
10 years, 6 months ago by eaeltsin

Modified:
9 years, 7 months ago

Reviewers:
khim, pasko-google - do not use

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@chromiumos-git/nacl-toolchain.git

Visibility:
Public.

Description

[gcc] Kill NACL_LEA_MATCH_ADDRESS_OPERAND and insn_is_nacl_lea. This is a cleanup change - removing stuff made no-op by new contsraint for LEA memory operand.

Patch Set 1 #

Patch Set 2 : ready for code review #

Total comments: 1

Patch Set 3 : prepare to commit #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -167 lines)			Patch
M	gcc/gcc/caller-save.c	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	gcc/gcc/config/i386/i386.c	View	2 chunks	+0 lines, -46 lines	0 comments	Download
M	gcc/gcc/config/i386/i386-protos.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gcc/gcc/final.c	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	gcc/gcc/genattrtab.c	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	gcc/gcc/ira.c	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	gcc/gcc/postreload.c	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	gcc/gcc/recog.c	View	4 chunks	+3 lines, -36 lines	0 comments	Download
M	gcc/gcc/regrename.c	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	gcc/gcc/reload.c	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	gcc/gcc/reload1.c	View	7 chunks	+2 lines, -32 lines	0 comments	Download
M	gcc/gcc/sel-sched.c	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pasko-google - do not use

10 years, 6 months ago (2010-06-24 17:57:20 UTC) #2

LGTM (!!!!!!)

my favorite!

http://codereview.chromium.org/2866019/diff/2001/3003
File gcc/gcc/config/i386/i386.c (left):

http://codereview.chromium.org/2866019/diff/2001/3003#oldcode9024
gcc/gcc/config/i386/i386.c:9024: -      return get_attr_type (insn) == TYPE_LEA;
I'll be missing this that grows from the get_attr_type() side effects :)

Expand Messages | Collapse Messages