Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2866018: Revert 50647 - Create HttpAuthController.... (Closed)

Created:
10 years, 6 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 50647 - Create HttpAuthController. 'Memory tests' is not happy. This packages up the auth state into a single class to enable a HttpProxyClientSocket class (which is needed for SSLClientSocketPool). BUG=30357 TEST=existing unit tests Review URL: http://codereview.chromium.org/2808020 TBR=vandebo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -539 lines) Patch
M net/base/net_error_list.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_auth.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_auth.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D net/http/http_auth_controller.h View 1 chunk +0 lines, -135 lines 0 comments Download
D net/http/http_auth_controller.cc View 1 chunk +0 lines, -331 lines 0 comments Download
M net/http/http_network_transaction.h View 3 chunks +74 lines, -6 lines 0 comments Download
M net/http/http_network_transaction.cc View 12 chunks +335 lines, -52 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vandebo (ex-Chrome)
10 years, 6 months ago (2010-06-23 23:35:55 UTC) #1
cbentzel
where were the memory tests failing? On Wed, Jun 23, 2010 at 7:35 PM, <vandebo@chromium.org> ...
10 years, 6 months ago (2010-06-24 11:04:51 UTC) #2
vandebo (ex-Chrome)
10 years, 6 months ago (2010-06-24 15:32:30 UTC) #3
On 2010/06/24 11:04:51, cbentzel wrote:
> where were the memory tests failing?

In 'Memory tests' on the memory waterfall:
http://build.chromium.org/buildbot/memory/builders/Linux%20Heapcheck/builds/4...

Fix was simple: http://codereview.chromium.org/2808020/diff2/22001:1008/7006

Powered by Google App Engine
This is Rietveld 408576698