Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome_frame/test/no_interference_test.cc

Issue 2866013: The ChromeFrame JavascriptWindowOpen test tries to open a popup in the onload... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/data/no_interference/window_open.html ('k') | chrome_frame/test/test_mock_with_web_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/no_interference_test.cc
===================================================================
--- chrome_frame/test/no_interference_test.cc (revision 50265)
+++ chrome_frame/test/no_interference_test.cc (working copy)
@@ -136,7 +136,12 @@
testing::StrictMock<MockWebBrowserEventSink> > new_window_mock;
mock_.ExpectNavigationInIE(kWindowOpenUrl);
- EXPECT_CALL(mock_, OnIELoad(testing::StrCaseEq(kWindowOpenUrl)));
+ EXPECT_CALL(mock_, OnIELoad(testing::StrCaseEq(kWindowOpenUrl)))
+ .WillOnce(testing::DoAll(
+ DelaySendMouseClickToIE(&mock_, &loop_, 0, 100, 100,
+ simulate_input::LEFT),
+ DelaySendMouseClickToIE(&mock_, &loop_, 0, 100, 100,
+ simulate_input::LEFT)));
mock_.ExpectNewWindowWithIE(empty_page_url(), &new_window_mock);
EXPECT_CALL(new_window_mock, OnIELoad(testing::StrCaseEq(empty_page_url())))
« no previous file with comments | « chrome_frame/test/data/no_interference/window_open.html ('k') | chrome_frame/test/test_mock_with_web_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698