Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2865034: Mark WorkerTest.QueuedSharedWorkerStartedFromOtherTab as flaky on Mac. (Closed)

Created:
10 years, 5 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Mark WorkerTest.QueuedSharedWorkerStartedFromOtherTab as flaky on Mac. BUG=48148 TEST=green tree Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51479

Patch Set 1 #

Total comments: 2

Patch Set 2 : 80 column #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/worker/worker_uitest.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
vandebo (ex-Chrome)
10 years, 5 months ago (2010-07-02 01:25:10 UTC) #1
stuartmorgan
http://codereview.chromium.org/2865034/diff/1/2 File chrome/worker/worker_uitest.cc (right): http://codereview.chromium.org/2865034/diff/1/2#newcode642 chrome/worker/worker_uitest.cc:642: #define MAYBE_QueuedSharedWorkerStartedFromOtherTab FLAKY_QueuedSharedWorkerStartedFromOtherTab 80 chars http://codereview.chromium.org/2865034/diff/1/2#newcode644 chrome/worker/worker_uitest.cc:644: #define MAYBE_QueuedSharedWorkerStartedFromOtherTab ...
10 years, 5 months ago (2010-07-02 01:27:08 UTC) #2
vandebo (ex-Chrome)
10 years, 5 months ago (2010-07-02 01:31:13 UTC) #3
stuartmorgan
10 years, 5 months ago (2010-07-02 01:59:51 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698