remoting: Extract the utility to get the BytesPerPixel from PixelFormat into a function.

remoting: Extract the utility to get the BytesPerPixel from PixelFormat into a function.

Note: That was a TODO for hclam.

BUG=None
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50928

[tfarina, 2010-06-25 17:27:51]

Hi, could you review this to me?

[garykac, 2010-06-25 18:49:36]

LGTM

http://codereview.chromium.org/2865019/diff/1/2
File remoting/base/protocol_util.cc (right):

http://codereview.chromium.org/2865019/diff/1/2#newcode29
remoting/base/protocol_util.cc:29: case PixelFormatAscii:  return 1;
Probably not a big deal, but PixelFormatRgb32/24 are the most common and
PixelFormatAscii is really used only for testing.

We should re-order this so the most commonly occurring options are first, in
case the compiler decides to use a series of if-then-else's instead of a
lookup-table.

[tfarina, 2010-06-26 00:49:31]

On 2010/06/25 18:49:36, garykac wrote:
> LGTM
> 
> http://codereview.chromium.org/2865019/diff/1/2
> File remoting/base/protocol_util.cc (right):
> 
> http://codereview.chromium.org/2865019/diff/1/2#newcode29
> remoting/base/protocol_util.cc:29: case PixelFormatAscii:  return 1;
> Probably not a big deal, but PixelFormatRgb32/24 are the most common and
> PixelFormatAscii is really used only for testing.
> 
> We should re-order this so the most commonly occurring options are first, in
> case the compiler decides to use a series of if-then-else's instead of a
> lookup-table.

I kept the old order, so Rgb24 is now the first option in the switch. If it's
ok, I will commit this when tree opens.

[tfarina, 2010-06-26 03:58:03]

On 2010/06/25 18:49:36, garykac wrote:
> LGTM
> 
Committing now...