Assorted integration fixes.

Assorted integration fixes.

MSVC does not like bitfields with extra bits in them, so it made the GptEntry struct too big.

Fixed a missing return value in LoadFirmware().

Added some debug output.

Fixed calls to SetupTPM().

Tested with 'make && make runtests'.  No errors.

[vb, 2010-06-23 15:47:27]

Randall, a couple of comments/questions. 

Also, can you please add to the CL description some info on how you tested this.

http://codereview.chromium.org/2865014/diff/1/2
File firmware/lib/cgptlib/include/gpt.h (right):

http://codereview.chromium.org/2865014/diff/1/2#newcode102
firmware/lib/cgptlib/include/gpt.h:102: uint16_t gpt_att;
can we be sure that this takes 64 bits?

http://codereview.chromium.org/2865014/diff/1/3
File firmware/lib/vboot_firmware.c (right):

http://codereview.chromium.org/2865014/diff/1/3#newcode209
firmware/lib/vboot_firmware.c:209: return LOAD_FIRMWARE_SUCCESS;
how come we did not see a compilation warning for this?

[Randall Spangler, 2010-06-23 16:10:11]

http://codereview.chromium.org/2865014/diff/1/2
File firmware/lib/cgptlib/include/gpt.h (right):

http://codereview.chromium.org/2865014/diff/1/2#newcode102
firmware/lib/cgptlib/include/gpt.h:102: uint16_t gpt_att;
On 2010/06/23 15:47:27, vb wrote:
> can we be sure that this takes 64 bits?

We need to add sizeof() checks in our unit tests.  Will do that.

http://codereview.chromium.org/2865014/diff/1/3
File firmware/lib/vboot_firmware.c (right):

http://codereview.chromium.org/2865014/diff/1/3#newcode209
firmware/lib/vboot_firmware.c:209: return LOAD_FIRMWARE_SUCCESS;
On 2010/06/23 15:47:27, vb wrote:
> how come we did not see a compilation warning for this?

because it drops down to the return statement below.

[vb, 2010-06-23 16:15:07]

LGTM