Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Side by Side Diff: src/heap-profiler.cc

Issue 2865013: Heap profiler: perform a GC round before taking a snapshot (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 } 353 }
354 354
355 355
356 HeapSnapshot* HeapProfiler::TakeSnapshot(String* name) { 356 HeapSnapshot* HeapProfiler::TakeSnapshot(String* name) {
357 ASSERT(singleton_ != NULL); 357 ASSERT(singleton_ != NULL);
358 return singleton_->TakeSnapshotImpl(name); 358 return singleton_->TakeSnapshotImpl(name);
359 } 359 }
360 360
361 361
362 HeapSnapshot* HeapProfiler::TakeSnapshotImpl(const char* name) { 362 HeapSnapshot* HeapProfiler::TakeSnapshotImpl(const char* name) {
363 Heap::CollectAllGarbage(false);
363 HeapSnapshot* result = snapshots_->NewSnapshot(name, next_snapshot_uid_++); 364 HeapSnapshot* result = snapshots_->NewSnapshot(name, next_snapshot_uid_++);
364 HeapSnapshotGenerator generator(result); 365 HeapSnapshotGenerator generator(result);
365 generator.GenerateSnapshot(); 366 generator.GenerateSnapshot();
366 return result; 367 return result;
367 } 368 }
368 369
369 370
370 HeapSnapshot* HeapProfiler::TakeSnapshotImpl(String* name) { 371 HeapSnapshot* HeapProfiler::TakeSnapshotImpl(String* name) {
371 return TakeSnapshotImpl(snapshots_->GetName(name)); 372 return TakeSnapshotImpl(snapshots_->GetName(name));
372 } 373 }
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
762 GlobalHandles::MakeWeak(handle.location(), 763 GlobalHandles::MakeWeak(handle.location(),
763 static_cast<void*>(stack.start()), 764 static_cast<void*>(stack.start()),
764 StackWeakReferenceCallback); 765 StackWeakReferenceCallback);
765 } 766 }
766 767
767 768
768 #endif // ENABLE_LOGGING_AND_PROFILING 769 #endif // ENABLE_LOGGING_AND_PROFILING
769 770
770 771
771 } } // namespace v8::internal 772 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698