Issue 2865013: Heap profiler: perform a GC round before taking a snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2865013: Heap profiler: perform a GC round before taking a snapshot (Closed)

Created:
10 years, 6 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Heap profiler: perform a GC round before taking a snapshot to get rid of global object loaded from a snapshot. This eliminates the "double global object" issue. Thanks to Mads for suggesting this! Committed: http://code.google.com/p/v8/source/detail?r=4917

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -15 lines)			Patch
	M	src/heap-profiler.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	test/cctest/test-heap-profiler.cc	View		1 chunk	+2 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages