Working towards -Wextra...

Working towards -Wextra
- Make loops use {} instead of a ';' to make it clear there is no body to the loop.
- Remove checks of unsigned values for <0
- coordinates should be CGFloat, not NSUInteger.

BUG=34160
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49939

[Mark Mentovai, 2010-06-15 14:05:25]

LGO

http://codereview.chromium.org/2865003/diff/1/2
File base/third_party/dmg_fp/dtoa.cc (right):

http://codereview.chromium.org/2865003/diff/1/2#newcode3866
base/third_party/dmg_fp/dtoa.cc:3866: while(*--s == '0') {}
Put the tabs back. Throughout. This is third_party code.

Update README.chromium in this directory.

http://codereview.chromium.org/2865003/diff/1/3
File base/third_party/dmg_fp/g_fmt.cc (right):

http://codereview.chromium.org/2865003/diff/1/3#newcode49
base/third_party/dmg_fp/g_fmt.cc:49: while((*b++ = *s++)) {}
Tabs again.

http://codereview.chromium.org/2865003/diff/1/5
File chrome/browser/cocoa/objc_zombie.mm (left):

http://codereview.chromium.org/2865003/diff/1/5#oldcode278
chrome/browser/cocoa/objc_zombie.mm:278: if (zombieCount < 0)
Ha!

[TVL, 2010-06-15 14:18:48]

tabs back, readme done, also added a patch file.  can you take another peek?

[Mark Mentovai, 2010-06-15 14:35:40]

LG™

http://codereview.chromium.org/2865003/diff/13001/14004
File base/third_party/dmg_fp/mac_wextra.patch (right):

http://codereview.chromium.org/2865003/diff/13001/14004#newcode1
base/third_party/dmg_fp/mac_wextra.patch:1: Index: g_fmt.cc
Ensure svn:eol-style is set (not sure if you’ve got the auto-props thing that
will set it on commit.)

[TVL, 2010-06-16 12:51:35]

fyi - i'm taking the translate infobar out of this cl because it needs changes
so the tests pass.