Issue 2865002: Support for DIR_SOURCE_ROOT in a case of WebKit-only checkout....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2865002: Support for DIR_SOURCE_ROOT in a case of WebKit-only checkout.... (Closed)

Created:
10 years, 6 months ago by tkent

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Support for DIR_SOURCE_ROOT in a case of WebKit-only checkout. BUG=none TEST=none. It's hard to write tests for DIR_SOURCE_ROOT without DIR_SOURCE_ROOT. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49769

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -3 lines)			Patch
	M	base/base_paths_posix.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
	M	base/base_paths_win.cc	View	1	1 chunk	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM! http://codereview.chromium.org/2865002/diff/4001/5002 File base/base_paths_win.cc (right): http://codereview.chromium.org/2865002/diff/4001/5002#newcode117 base/base_paths_win.cc:117: // Check for WebKit-only checkout. Executablef iles are ...

10 years, 6 months ago (2010-06-15 06:46:56 UTC) #2

tkent

10 years, 6 months ago (2010-06-15 07:01:42 UTC) #3

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49769

http://codereview.chromium.org/2865002/diff/4001/5002
File base/base_paths_win.cc (right):

http://codereview.chromium.org/2865002/diff/4001/5002#newcode117
base/base_paths_win.cc:117: // Check for WebKit-only checkout. Executablef iles
are put into
Fixed.  Thanks.

Expand Messages | Collapse Messages