Issue 2864039: Revert 51572 - Clean up .grds, step 1: Alphabetize....

Issue 2864039: Revert 51572 - Clean up .grds, step 1: Alphabetize.... (Closed)

Created:
10 years, 5 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, cbentzel+watch_chromium.org, dpranke+watch_chromium.org, ben+cc_chromium.org, amit, arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 51572 - Clean up .grds, step 1: Alphabetize. BUG=none TEST=none Review URL: http://codereview.chromium.org/2838041 TBR=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51575

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+582 lines, -563 lines)			Patch
M	app/resources/app_resources.grd	View	1 chunk	+110 lines, -95 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	7 chunks	+346 lines, -353 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	2 chunks	+38 lines, -37 lines	0 comments	Download
M	chrome/browser/resources/bookmark_manager_resources.grd	View	1 chunk	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/resources/net_internals_resources.grd	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/shared_resources.grd	View	4 chunks	+21 lines, -14 lines	0 comments	Download
M	chrome/common/common_resources.grd	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/renderer/renderer_resources.grd	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome_frame/resources/chrome_frame_resources.grd	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	net/base/net_resources.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webkit_resources.grd	View	1 chunk	+35 lines, -34 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_resources.grd	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

10 years, 5 months ago (2010-07-03 00:17:19 UTC) #2

LGTM

erik



On Fri, Jul 2, 2010 at 16:40,  <pkasting@chromium.org> wrote:
> Reviewers: Peter Kasting,
>
> Description:
> Revert 51572 - Clean up .grds, step 1: Alphabetize.
>
> BUG=none
> TEST=none
> Review URL: http://codereview.chromium.org/2838041
>
> TBR=pkasting@chromium.org
>
> Please review this at http://codereview.chromium.org/2864039/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     app/resources/app_resources.grd
>  M     chrome/app/theme/theme_resources.grd
>  M     chrome/browser/browser_resources.grd
>  M     chrome/browser/resources/bookmark_manager_resources.grd
>  M     chrome/browser/resources/net_internals_resources.grd
>  M     chrome/browser/resources/shared_resources.grd
>  M     chrome/common/common_resources.grd
>  M     chrome/renderer/renderer_resources.grd
>  M     chrome_frame/resources/chrome_frame_resources.grd
>  M     net/base/net_resources.grd
>  M     webkit/glue/webkit_resources.grd
>  M     webkit/tools/test_shell/test_shell_resources.grd
>
>
>

Expand Messages | Collapse Messages