Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2864035: Fix up extension docs to include latest changes to how file URLs work with (Closed)

Created:
10 years, 5 months ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman, kathyw
CC:
chromium-reviews
Visibility:
Public.

Description

Fix up extension docs to include latest changes to how file URLs work with content scripts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51467

Patch Set 1 #

Total comments: 7

Patch Set 2 : feedback #

Patch Set 3 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -8 lines) Patch
M chrome/common/extensions/docs/match_patterns.html View 1 2 3 chunks +47 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/static/match_patterns.html View 1 2 3 chunks +48 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
10 years, 5 months ago (2010-07-01 21:30:17 UTC) #1
kathyw
Some copyedits. Do these changes take effect in M6? http://codereview.chromium.org/2864035/diff/1/3 File chrome/common/extensions/docs/static/match_patterns.html (right): http://codereview.chromium.org/2864035/diff/1/3#newcode19 chrome/common/extensions/docs/static/match_patterns.html:19: ...
10 years, 5 months ago (2010-07-01 22:15:39 UTC) #2
Matt Perry
Thanks Kathy, it's much better! http://codereview.chromium.org/2864035/diff/1/3 File chrome/common/extensions/docs/static/match_patterns.html (right): http://codereview.chromium.org/2864035/diff/1/3#newcode21 chrome/common/extensions/docs/static/match_patterns.html:21: on the available schemes. ...
10 years, 5 months ago (2010-07-02 00:00:45 UTC) #3
kathyw
LGTM Thanks for making those changes! Now could you remind me... When do these changes ...
10 years, 5 months ago (2010-07-02 00:14:51 UTC) #4
Matt Perry
10 years, 5 months ago (2010-07-02 00:25:55 UTC) #5
On 2010/07/02 00:14:51, kathyw wrote:
> LGTM
> 
> Thanks for making those changes!
> 
> Now could you remind me... When do these changes take effect? Are they out on
> dev channel yet?

They were added in this revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=51295

They missed this week's dev channel release, so they'll be in next week's.

Powered by Google App Engine
This is Rietveld 408576698