Issue 2864033: Make the localized product name 'ungarbled'. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2864033: Make the localized product name 'ungarbled'. ... (Closed)

Created:
10 years, 5 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make the localized product name 'ungarbled'. BUG=4456 TEST=Change the UI languge to Japanese and log out. At the lower-left corner of the login screen, there's no more sequence of 'black question marks'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52448

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/chromeos/login/background_view.cc	View	1 2 3	3 chunks	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

10 years, 5 months ago (2010-07-12 16:28:35 UTC) #3

http://codereview.chromium.org/2864033/diff/10001/11001
File chrome/browser/chromeos/login/background_view.cc (right):

http://codereview.chromium.org/2864033/diff/10001/11001#newcode244
chrome/browser/chromeos/login/background_view.cc:244: // Use UTF8ToWide once
this string is loclized.
nit: localized

Expand Messages | Collapse Messages