Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2864020: DevTools: Migrate to new WebView initialization (pass devtools client directly). (Closed)

Created:
10 years, 6 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews, jam+cc_chromium.org, pam+watch_chromium.org, dpranke+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

DevTools: Migrate to new WebView initialization (pass devtools client directly). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50726

Patch Set 1 #

Patch Set 2 : deps roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_agent.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_agent.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/webview_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/webview_host_win.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
pfeldman
10 years, 6 months ago (2010-06-24 11:55:16 UTC) #1
yurys
10 years, 6 months ago (2010-06-24 12:01:33 UTC) #2
On 2010/06/24 11:55:16, pfeldman wrote:
> 
LGTM

Powered by Google App Engine
This is Rietveld 408576698