Issue 2863034: Up the warnings in ipc...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2863034: Up the warnings in ipc... (Closed)

Created:
10 years, 5 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, John Grabowski

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Up the warnings in ipc - add chromium_code:1 to the GYP file - Fix some unittest compares of literal 0 to apis that return size_t - initializer order match declared order - type_id is a uint32, so fix up comparison warnings by using the right type in the test code. BUG=none TEST=everything still builds/works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51520

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -13 lines)			Patch
M	ipc/ipc.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ipc/ipc_channel_posix.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ipc/ipc_fuzzing_tests.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	ipc/ipc_sync_channel_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ipc/sync_socket_unittest.cc	View	2 chunks	+3 lines, -3 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

10 years, 5 months ago (2010-06-30 18:30:22 UTC) #2

LGTM

http://codereview.chromium.org/2863034/diff/1/6
File ipc/sync_socket_unittest.cc (right):

http://codereview.chromium.org/2863034/diff/1/6#newcode198
ipc/sync_socket_unittest.cc:198: EXPECT_EQ(static_cast<size_t>(0),
socket_->Peek());
0U

http://codereview.chromium.org/2863034/diff/1/6#newcode223
ipc/sync_socket_unittest.cc:223: EXPECT_EQ(static_cast<size_t>(0),
pair[0]->Peek());
Throughout.

Expand Messages | Collapse Messages