Chromium Code Reviews

Issue 2863003: Attempt 2 at: (Closed)

Created:
10 years, 6 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Ben Goodger (Google)
CC:
chromium-reviews
Visibility:
Public.

Description

Attempt 2 at: Changes the tab close button to a dot, unless you're near the button or the tab is selected. The only difference between this and the first is that I missed a remove from the set if the view was deleted, which resulted in a crash. I've added an interactive test case that covers this. BUG=45743 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49828

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+351 lines, -49 lines)
M chrome/browser/views/tabs/base_tab.h View 5 chunks +11 lines, -3 lines 0 comments
M chrome/browser/views/tabs/base_tab.cc View 7 chunks +89 lines, -9 lines 0 comments
M chrome/browser/views/tabs/side_tab.cc View 2 chunks +2 lines, -6 lines 0 comments
M chrome/browser/views/tabs/tab.cc View 5 chunks +18 lines, -8 lines 0 comments
M chrome/browser/views/tabs/tab_strip.cc View 1 chunk +7 lines, -2 lines 0 comments
A chrome/browser/views/tabs/tab_strip_interactive_uitest.cc View 1 chunk +59 lines, -0 lines 0 comments
M chrome/test/interactive_ui/interactive_ui_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments
M views/controls/button/image_button.h View 2 chunks +12 lines, -7 lines 0 comments
M views/event.h View 2 chunks +5 lines, -1 line 0 comments
M views/view.h View 4 chunks +25 lines, -5 lines 0 comments
M views/view.cc View 4 chunks +25 lines, -8 lines 0 comments
M views/widget/root_view.h View 4 chunks +24 lines, -0 lines 0 comments
M views/widget/root_view.cc View 4 chunks +72 lines, -0 lines 0 comments

Messages

Total messages: 2 (0 generated)
sky
10 years, 6 months ago (2010-06-15 18:23:23 UTC) #1
Ben Goodger (Google)
10 years, 6 months ago (2010-06-15 18:39:00 UTC) #2
OK

Powered by Google App Engine