Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2862041: Remove abonded privacy blacklist implementation. (Closed)

Created:
10 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Remove abonded privacy blacklist implementation. BUG=16932 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51525

Patch Set 1 #

Patch Set 2 : fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1560 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 5 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 5 chunks +0 lines, -43 lines 0 comments Download
M chrome/browser/options_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/privacy_blacklist/blacklist.h View 1 chunk +0 lines, -227 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist.cc View 1 chunk +0 lines, -223 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist_interceptor.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist_interceptor.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist_interceptor_unittest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist_perftest.cc View 1 chunk +0 lines, -214 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist_request_info.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist_request_info.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist_ui.h View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist_ui.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/privacy_blacklist/blacklist_unittest.cc View 1 chunk +0 lines, -248 lines 0 comments Download
M chrome/browser/profile.h View 4 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/profile.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 4 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 5 chunks +0 lines, -29 lines 0 comments Download
D chrome/browser/resources/privacy_blacklist_block.html View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/resources/privacy_blacklist_block.png View Binary file 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/blacklist.pbl View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json View 1 1 chunk +1 line, -2 lines 0 comments Download
D chrome/test/data/profiles/blacklist_prefs/Preferences View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/test/testing_profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_context.h View 1 chunk +0 lines, -14 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
please review.
10 years, 5 months ago (2010-07-02 12:44:28 UTC) #1
Paweł Hajdan Jr.
LGTM
10 years, 5 months ago (2010-07-02 13:17:34 UTC) #2
Peter Kasting
10 years, 5 months ago (2010-07-02 18:01:34 UTC) #3 
I didn't actually look at any of this as it was going in, so I'm inclined to
waive off reviewing.  Did you need more than a rubber stamp from me?  If not,
feel free to land.

Powered by Google App Engine
This is Rietveld 408576698