Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2862039: Add gclient recurse (Closed)

Created:
10 years, 5 months ago by piman
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Add gclient recurse This allows to recurse in all the entries to operate on them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51419

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding smoketest #

Total comments: 5

Patch Set 3 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M gclient.py View 1 2 2 chunks +30 lines, -0 lines 0 comments Download
M tests/gclient_smoketest.py View 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
piman
10 years, 5 months ago (2010-07-01 18:25:53 UTC) #1
M-A Ruel
I want a small smoke test though. It's fairly easy to write now. http://codereview.chromium.org/2862039/diff/1/2 File ...
10 years, 5 months ago (2010-07-01 18:30:09 UTC) #2
piman
http://codereview.chromium.org/2862039/diff/1/2 File gclient.py (right): http://codereview.chromium.org/2862039/diff/1/2#newcode864 gclient.py:864: Runs a shell command on all entries. On 2010/07/01 ...
10 years, 5 months ago (2010-07-01 19:36:48 UTC) #3
M-A Ruel
lgtm with small nits http://codereview.chromium.org/2862039/diff/5001/6001 File gclient.py (right): http://codereview.chromium.org/2862039/diff/5001/6001#newcode871 gclient.py:871: root, entries = gclient_utils.GetGClientRootAndEntries() I'll ...
10 years, 5 months ago (2010-07-01 19:50:26 UTC) #4
piman
10 years, 5 months ago (2010-07-01 20:28:53 UTC) #5
http://codereview.chromium.org/2862039/diff/5001/6001
File gclient.py (right):

http://codereview.chromium.org/2862039/diff/5001/6001#newcode877
gclient.py:877: env = os.environ
On 2010/07/01 19:50:26, Marc-Antoine Ruel wrote:
> env = os.environ.copy() just in case

Done.

http://codereview.chromium.org/2862039/diff/5001/6002
File tests/gclient_smoketest.py (right):

http://codereview.chromium.org/2862039/diff/5001/6002#newcode675
tests/gclient_smoketest.py:675: entries = set()
On 2010/07/01 19:50:26, Marc-Antoine Ruel wrote:
> I'd prefer a sorted list than a set, for the reason that running the same deps
2
> times is a bug. You can just change line 693 to
> self.assertEquals(sorted(entries), sorted(expected))

Done.

Powered by Google App Engine
This is Rietveld 408576698