Fix crash in GetSpdySessionFromSSLSocket in the case where the...

Fix crash in GetSpdySessionFromSSLSocket in the case where the
server immediately hangs up after negotiating SPDY via NPN.

BUG=46369
TEST=SpdyNPNServerHangup

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50689

[willchan no longer on Chromium, 2010-06-23 21:15:27]

LGTM

http://codereview.chromium.org/2862027/diff/7001/8001
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/2862027/diff/7001/8001#newcode1518
net/http/http_network_transaction.cc:1518: spdy_session =
spdy_pool->GetSpdySessionFromSSLSocket(
It's more of a nit than anything, but this feels slightly ugly to me.  I sorta
feel like, if we know that the session already errored out, then the pool
shouldn't be returning a session.  I don't like having to trust the client to
make sure it checks the error before trying to use the session.  Perhaps the
right solution is to have GetSpdySessionFromSSLSocket() return a net error code.

http://codereview.chromium.org/2862027/diff/7001/8001#newcode1522
net/http/http_network_transaction.cc:1522: DCHECK(error != OK);
DCHECK_NE

http://codereview.chromium.org/2862027/diff/7001/8003
File net/spdy/spdy_session.cc (right):

http://codereview.chromium.org/2862027/diff/7001/8003#newcode350
net/spdy/spdy_session.cc:350: CHECK(state_ != CLOSED);
CHECK_NE

[Mike Belshe, 2010-06-23 23:13:33]

lgtm