Issue 2862019: Provide a means of including BIOS specific definitions when required.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2862019: Provide a means of including BIOS specific definitions when required. (Closed)

Created:
10 years, 6 months ago by vb

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/vboot_reference.git

Visibility:
Public.

Description

Include BIOS specific definitions when required. This is a noop for host/chroot environment. When compiling in the firmware space the standard include files will not be included, the definitions will be supplied by the BIOS, through the new file (firmware/include/sysincludes.h). Testing ======= RUNTESTS=1 make in the top level directory succeeds, confirming that the tree compiles cleanly and the unit tests pass.

Patch Set 1 #

Patch Set 2 : Modify attributes fieldi size to comply with msc limitations #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -1 line)			Patch
M	Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	firmware/include/sysincludes.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
A	firmware/stub/biosincludes.h	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks!

Expand Messages | Collapse Messages