Issue 2861042: Deprecate more old filepath functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2861042: Deprecate more old filepath functions. (Closed)

Created:
10 years, 5 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, dpranke+watch_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Visibility:
Public.

Description

Deprecate more old filepath functions. These still exist on Windows due to being used by the installer, but by moving them into the Windows-only block we prevent them from being used in new code. BUG=24672 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51453

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -14 lines)			Patch
M	base/file_util_deprecated.h	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	base/file_util_unittest.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_controller.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	views/drag_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

10 years, 5 months ago (2010-07-01 23:11:47 UTC) #2

LGTM. Too bad you can't just delete this outright.

Expand Messages | Collapse Messages