Issue 2861040: Hide the browser actions gripper when it's not in use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2861040: Hide the browser actions gripper when it's not in use. (Closed)

Created:
10 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Hide the browser actions gripper when it's not in use. BUG=45765 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51475

Patch Set 2 : fix fixme #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	chrome/browser/gtk/browser_actions_toolbar_gtk.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/gtk/browser_actions_toolbar_gtk.cc	View		4 chunks	+14 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/2861040/diff/3001/4001 File chrome/browser/gtk/browser_actions_toolbar_gtk.cc (right): http://codereview.chromium.org/2861040/diff/3001/4001#newcode784 chrome/browser/gtk/browser_actions_toolbar_gtk.cc:784: draw_gripper_ = true; How come you don't queue_draw here ...

10 years, 5 months ago (2010-07-01 16:40:14 UTC) #2

Evan Stade

10 years, 5 months ago (2010-07-01 17:35:08 UTC) #3

Ah, ok. LGTM

Expand Messages | Collapse Messages

Issue 2861040: Hide the browser actions gripper when it's not in use. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix fixme #

Messages