Add EnableInputMethodsAndKeyboardLayouts function

Add EnableInputMethodsAndKeyboardLayouts function. 

I'll use the function to implement crosbug.com/2619 (Implement input language selector on the log in page) 

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51220

[satorux1, 2010-06-25 05:14:18]

LGTM, for minor nits below:

http://codereview.chromium.org/2861022/diff/2001/3001
File chrome/browser/chromeos/input_method/input_method_util.cc (right):

http://codereview.chromium.org/2861022/diff/2001/3001#newcode586
chrome/browser/chromeos/input_method/input_method_util.cc:586: }
This seems to to be a rare occasion where you can use std::find() or std:count()
? :)

http://codereview.chromium.org/2861022/diff/2001/3002
File chrome/browser/chromeos/input_method/input_method_util.h (right):

http://codereview.chromium.org/2861022/diff/2001/3002#newcode131
chrome/browser/chromeos/input_method/input_method_util.h:131: // This function
is only for unit tests. Do not use this.
What about moving this and SortInputMethodIdsByNamesInternal() to the end of the
file, and having a line like:

// DO NOT USE Functions below. These are only exported for unit tests.

http://codereview.chromium.org/2861022/diff/2001/3002#newcode145
chrome/browser/chromeos/input_method/input_method_util.h:145: const std::string&
locale, bool keyboard_layout_only,
In this file, "language code" is used instead of "locale" for historical
reasons. Would be nice to make it consistent.

[satorux1, 2010-06-26 03:27:44]

http://codereview.chromium.org/2861022/diff/2001/3002
File chrome/browser/chromeos/input_method/input_method_util.h (right):

http://codereview.chromium.org/2861022/diff/2001/3002#newcode144
chrome/browser/chromeos/input_method/input_method_util.h:144: void
EnableInputMethodsAndKeyboardLayouts(
BTW, what about calling it EnableInputMethods() to be consistent with other
functions in this file?

InputMethod is a bit misleading but InputMethodAndKeyboardLayout is a bit too
long. Until we find a better name, we could go with InputMethod.

[satorux1, 2010-06-26 04:10:58]

http://codereview.chromium.org/2861022/diff/2001/3002
File chrome/browser/chromeos/input_method/input_method_util.h (right):

http://codereview.chromium.org/2861022/diff/2001/3002#newcode145
chrome/browser/chromeos/input_method/input_method_util.h:145: const std::string&
locale, bool keyboard_layout_only,
See comments about the boolean parameter at
http://codereview.chromium.org/2806026/show

[Yusuke Sato, 2010-06-28 02:00:00]

http://codereview.chromium.org/2861022/diff/2001/3001
File chrome/browser/chromeos/input_method/input_method_util.cc (right):

http://codereview.chromium.org/2861022/diff/2001/3001#newcode586
chrome/browser/chromeos/input_method/input_method_util.cc:586: }
On 2010/06/25 05:14:18, satorux1 wrote:
> This seems to to be a rare occasion where you can use std::find() or
std:count()
> ? :)

Done.

http://codereview.chromium.org/2861022/diff/2001/3002
File chrome/browser/chromeos/input_method/input_method_util.h (right):

http://codereview.chromium.org/2861022/diff/2001/3002#newcode131
chrome/browser/chromeos/input_method/input_method_util.h:131: // This function
is only for unit tests. Do not use this.
On 2010/06/25 05:14:18, satorux1 wrote:
> What about moving this and SortInputMethodIdsByNamesInternal() to the end of
the
> file, and having a line like:
> 
> // DO NOT USE Functions below. These are only exported for unit tests.

Done.

http://codereview.chromium.org/2861022/diff/2001/3002#newcode144
chrome/browser/chromeos/input_method/input_method_util.h:144: void
EnableInputMethodsAndKeyboardLayouts(
On 2010/06/26 03:27:44, satorux1 wrote:
> BTW, what about calling it EnableInputMethods() to be consistent with other
> functions in this file?
> 
> InputMethod is a bit misleading but InputMethodAndKeyboardLayout is a bit too
> long. Until we find a better name, we could go with InputMethod.

Done.

http://codereview.chromium.org/2861022/diff/2001/3002#newcode145
chrome/browser/chromeos/input_method/input_method_util.h:145: const std::string&
locale, bool keyboard_layout_only,
On 2010/06/25 05:14:18, satorux1 wrote:
> In this file, "language code" is used instead of "locale" for historical
> reasons. Would be nice to make it consistent.

Done.

http://codereview.chromium.org/2861022/diff/2001/3002#newcode145
chrome/browser/chromeos/input_method/input_method_util.h:145: const std::string&
locale, bool keyboard_layout_only,
On 2010/06/26 04:10:58, satorux1 wrote:
> See comments about the boolean parameter at
> http://codereview.chromium.org/2806026/show

Done.

[satorux1, 2010-06-28 02:06:18]

LGTM

http://codereview.chromium.org/2861022/diff/11001/12001
File chrome/browser/chromeos/input_method/input_method_util.cc (right):

http://codereview.chromium.org/2861022/diff/11001/12001#newcode590
chrome/browser/chromeos/input_method/input_method_util.cc:590:
kHardwareKeyboardLayout)) {
== 0 ?

[Yusuke Sato, 2010-06-30 03:25:32]

done. submitting..

http://codereview.chromium.org/2861022/diff/11001/12001
File chrome/browser/chromeos/input_method/input_method_util.cc (right):

http://codereview.chromium.org/2861022/diff/11001/12001#newcode590
chrome/browser/chromeos/input_method/input_method_util.cc:590:
kHardwareKeyboardLayout)) {
On 2010/06/28 02:06:18, satorux1 wrote:
> == 0 ?

Done.