Issue 2861020: Refactor rollback interface for LoadKernel(), LoadFirmware().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2861020: Refactor rollback interface for LoadKernel(), LoadFirmware(). (Closed)

Created:
10 years, 6 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/vboot_reference.git

Visibility:
Public.

Description

Refactor rollback interface for LoadKernel(), LoadFirmware().

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -44 lines)			Patch
M	firmware/include/rollback_index.h	View	1 chunk	+52 lines, -0 lines	0 comments	Download
M	firmware/lib/rollback_index.c	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	firmware/lib/vboot_firmware.c	View	2 chunks	+5 lines, -13 lines	0 comments	Download
M	firmware/lib/vboot_kernel.c	View	2 chunks	+17 lines, -26 lines	0 comments	Download
M	firmware/linktest/main.c	View	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

10 years, 6 months ago (2010-06-23 22:53:35 UTC) #2

LGTM in any case

The only question I have is whether you want to indicate in a comment before the
call to RollbackKernelLock that the function will not lock if we're in recovery
mode.

Expand Messages | Collapse Messages