Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: media/audio/audio_controller.h

Issue 2861010: Some fixups for AudioController and unit tests (Closed)
Patch Set: fixes Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/audio_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_controller.h
diff --git a/media/audio/audio_controller.h b/media/audio/audio_controller.h
index 21d6d227d6323b2919ad8db01b68874ae8c2f5d3..7b02af4b55aebc0c19b64d184725b0160b431df5 100644
--- a/media/audio/audio_controller.h
+++ b/media/audio/audio_controller.h
@@ -107,7 +107,7 @@ class AudioController : public base::RefCountedThreadSafe<AudioController>,
int channels, // Number of channels.
int sample_rate, // Sampling frequency/rate.
int bits_per_sample, // Number of bits per sample.
- int hardware_buffer_size, // Size of the hardware buffer.
+ uint32 hardware_buffer_size, // Size of the hardware buffer.
// Soft limit for buffer capacity in this controller. This parameter
// is used only in regular latency mode.
@@ -120,7 +120,7 @@ class AudioController : public base::RefCountedThreadSafe<AudioController>,
int channels, // Number of channels.
int sample_rate, // Sampling frequency/rate.
int bits_per_sample, // Number of bits per sample.
- int hardware_buffer_size, // Size of the hardware buffer.
+ uint32 hardware_buffer_size, // Size of the hardware buffer.
// External synchronous reader for audio controller.
SyncReader* sync_reader);
@@ -140,6 +140,9 @@ class AudioController : public base::RefCountedThreadSafe<AudioController>,
// Closes the audio output stream and shutdown the audio controller thread.
// This method returns only after all operations are completed. This
// controller cannot be used after this method is called.
+ //
+ // It is safe to call this method more than once. Calls after the first one
+ // will have no effect.
void Close();
// Sets the volume of the audio output stream.
@@ -150,6 +153,8 @@ class AudioController : public base::RefCountedThreadSafe<AudioController>,
// SyncReader is present.
void EnqueueData(const uint8* data, uint32 size);
+ bool LowLatencyMode() const { return sync_reader_ != NULL; }
+
///////////////////////////////////////////////////////////////////////////
// AudioSourceCallback methods.
virtual uint32 OnMoreData(AudioOutputStream* stream, void* dest,
@@ -164,7 +169,7 @@ class AudioController : public base::RefCountedThreadSafe<AudioController>,
// The following methods are executed on the audio controller thread.
void DoCreate(AudioManager::Format format, int channels,
int sample_rate, int bits_per_sample,
- int hardware_buffer_size);
+ uint32 hardware_buffer_size);
void DoPlay();
void DoPause();
void DoFlush();
« no previous file with comments | « no previous file | media/audio/audio_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698