Issue 2860030: Fixes a DCHECK when visiting chrome://theme....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2860030: Fixes a DCHECK when visiting chrome://theme.... (Closed)

Created:
10 years, 6 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes a DCHECK when visiting chrome://theme. This URL sets off an error case that calls RDH::OnReadCompleted without calling RDH::Read. ResourceDispatcherHost then tries to read from a failed request. We can avoid this by ensuring has_started_reading is true when OnReadCompleted is called (whether Read is called or not). BUG=40250 TEST=ResourceDispatcherHostUITest.CrossSiteFailedRequest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51037

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/resource_dispatcher_host.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

It would take me several hours to understand the ramifications of the possibilities your outlined ...

10 years, 5 months ago (2010-06-28 17:13:14 UTC) #2

Charlie Reis

10 years, 5 months ago (2010-06-28 17:29:00 UTC) #3

Thanks-- fixed CL uploaded, and I'll land it later today.

http://codereview.chromium.org/2860030/diff/1/3
File chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc (right):

http://codereview.chromium.org/2860030/diff/1/3#newcode330
chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc:330: GURL
url("chrome://newtab");
On 2010/06/28 17:13:15, brettw wrote:
> Maybe use chrome::kChromeUINewTabURL?

Done.

http://codereview.chromium.org/2860030/diff/1/3#newcode337
chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc:337: // Make
sure the navigation finishes
On 2010/06/28 17:13:15, brettw wrote:
> Don't forget period for comment.

Done.

Expand Messages | Collapse Messages