gfx/gtk_native_view_id_manager.cc - Issue 2860024: GTK: add more syncronization to GtkNativeViewIdManager to avoid a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gfx/gtk_native_view_id_manager.cc

Issue 2860024: GTK: add more syncronization to GtkNativeViewIdManager to avoid a crash. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: lock acquisition order Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gfx/gtk_native_view_id_manager.cc

diff --git a/gfx/gtk_native_view_id_manager.cc b/gfx/gtk_native_view_id_manager.cc

index 47dc2fbe037432d6fb84713884ef8d07788df084..91407283a01272f66cad19be08fc375caa766c01 100644

--- a/gfx/gtk_native_view_id_manager.cc

+++ b/gfx/gtk_native_view_id_manager.cc

@@ -116,6 +116,7 @@ void GtkNativeViewManager::OnRealize(gfx::NativeView widget) {

}

void GtkNativeViewManager::OnUnrealize(gfx::NativeView widget) {

+ AutoLock unrealize_locked(unrealize_lock_);

AutoLock locked(lock_);

const gfx::NativeViewId id = GetWidgetId(widget);

« no previous file with comments | « gfx/gtk_native_view_id_manager.h ('k') | no next file » | no next file with comments »