Adding a mutator method for the private variables.

Adding a mutator method for the private variables.

BUG=38736
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50666

[apatrick, 2010-06-23 17:10:03]

LGTM

http://codereview.chromium.org/2860016/diff/1/2
File chrome/gpu/gpu_info.h (right):

http://codereview.chromium.org/2860016/diff/1/2#newcode48
chrome/gpu/gpu_info.h:48: void SetGraphicsInfo(const uint32 vendor_id, const
uint32 device_id,
We don't normally use const on parameters unless its a const reference. There's
nothing wrong with it but you might consider consistency. We normally pass
std::string parameters as const std::string& to avoid a copy.

[rpetterson, 2010-06-23 21:37:33]

Fixed the one item. Thanks for LTGM.

http://codereview.chromium.org/2860016/diff/1/2
File chrome/gpu/gpu_info.h (right):

http://codereview.chromium.org/2860016/diff/1/2#newcode48
chrome/gpu/gpu_info.h:48: void SetGraphicsInfo(const uint32 vendor_id, const
uint32 device_id,
On 2010/06/23 17:10:03, apatrick wrote:
> We don't normally use const on parameters unless its a const reference.
There's
> nothing wrong with it but you might consider consistency. We normally pass
> std::string parameters as const std::string& to avoid a copy.

Fixed to maintain consistency. Thanks for pointing it out.