Allow slightly larger browser and page action icons.

Allow slightly larger browser and page action icons.

This allows 19px icons to be able to be used for both
browser and page icons.

I think it looks nicer with the page actions slightly smaller, and that is what we also usually do in Chrome,
but some Chrome location bar icons use 18px for soft edges,
so I guess this will just have to be something we advise
developers on.

We can actually fit up to 21 (whoa nelly) pixels on Windows,
but apparently the space is slightly smaller on mac.

Also minor layout fix. We were sizing the browser action
buttons 1px too short.

BUG=24881
TEST=Load chrome/test/data/extensions/samples/icon_size_test. Icons should be 17px for the page action and 19px for the browser action and centered nicely in the space.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29365

[Erik does not do reviews, 2009-10-16 15:23:46]

other than this, LGTM

http://codereview.chromium.org/286001/diff/1001/2003
File chrome/browser/gtk/browser_actions_toolbar_gtk.cc (right):

http://codereview.chromium.org/286001/diff/1001/2003#newcode29
Line 29: static const int kMaxIconSize = 19;
if we're going to standardize the icon size across platforms, then it would be
good if we could put this constant (and the one for page size) in a shared
location.

[Aaron Boodman, 2009-10-16 15:56:40]

Shared constant.

Also, I noticed that the SSL lock icon is 18px tall, so I guess we need all 19
afterall for the location bar. I guess we should probably have a section in the
docs for both page and browser icons that shows examples of good ones and gives
some advice.

[Erik does not do reviews, 2009-10-16 16:02:29]

LGTM