Issue 2859039: Refactor the dot graph generation out of cros_generate_deps_graphs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2859039: Refactor the dot graph generation out of cros_generate_deps_graphs (Closed)

Created:
10 years, 5 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git//crosutils.git

Visibility:
Public.

Description

Refactor the dot graph generation out of cros_generate_deps_graphs This will be re-used by a separate tool

Patch Set 2 : address review comments #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -47 lines)			Patch
	M	cros_generate_deps_graphs	View		5 chunks	+23 lines, -47 lines	0 comments	Download
	A	dot_helper.py	View	1	1 chunk	+116 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sosa

Google copyright in dot_helper? Otherwise a nit, o/w LGTM http://codereview.chromium.org/2859039/diff/1/3 File dot_helper.py (right): http://codereview.chromium.org/2859039/diff/1/3#newcode6 dot_helper.py:6: ...

10 years, 5 months ago (2010-07-01 19:41:22 UTC) #2

piman

http://codereview.chromium.org/2859039/diff/1/3 File dot_helper.py (right): http://codereview.chromium.org/2859039/diff/1/3#newcode6 dot_helper.py:6: # Copyright 2010 Google Inc. All Rights Reserved. On ...

10 years, 5 months ago (2010-07-01 20:41:10 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 2859039: Refactor the dot graph generation out of cros_generate_deps_graphs (Closed)

Description

Patch Set 1 #

Patch Set 2 : address review comments #

Messages