ChromeFrame perf tests now depend on Chrome's reference build. The ChromeFram...

ChromeFrame perf tests now depend on Chrome's reference build. The ChromeFrame reference build under 
trunk/deps/reference_builds/chrome_frame will be deleted in a separate CL. This fixes a crash while running
chrome frame perf tests on the perf builder.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51060

[amit, 2010-06-28 22:48:27]

lgtm

On Mon, Jun 28, 2010 at 3:44 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> ChromeFrame perf tests now depend on Chrome's reference build. The
> ChromeFrame
> reference build under
> trunk/deps/reference_builds/chrome_frame will be deleted in a separate CL.
> This
> fixes a crash while running
> chrome frame perf tests on the perf builder.
>
>
> Please review this at http://codereview.chromium.org/2859031/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>  M     chrome_frame/test_utils.cc
>
>
> Index: DEPS
> ===================================================================
> --- DEPS        (revision 51042)
> +++ DEPS        (working copy)
> @@ -1,7 +1,7 @@
>  vars = {
>   "webkit_trunk":
>   "http://svn.webkit.org/repository/webkit/trunk",
> -  "webkit_revision": "62015",
> +  "webkit_revision": "61996",
>   "ffmpeg_revision": "49485",
>   "skia_revision": "583",
>   "chromium_git": "http://src.chromium.org/git",
> @@ -184,7 +184,7 @@
>     "src/third_party/xulrunner-sdk":
>       "/trunk/deps/third_party/xulrunner-sdk@17887",
>     "src/chrome_frame/tools/test/reference_build/chrome":
> -      "/trunk/deps/reference_builds/chrome_frame@33840",
> +      "/trunk/deps/reference_builds/chrome@41984",
>
>     # Parses Windows PE/COFF executable format.
>     "src/third_party/pefile":
> Index: chrome_frame/test_utils.cc
> ===================================================================
> --- chrome_frame/test_utils.cc  (revision 51042)
> +++ chrome_frame/test_utils.cc  (working copy)
> @@ -21,7 +21,6 @@
>
>  const wchar_t kChromeFrameDllName[] = L"npchrome_frame.dll";
>  const wchar_t kChromeLauncherExeName[] = L"chrome_launcher.exe";
> -const char kReferenceChromeFrameDllName[] = "npchrome_tab.dll";
>
>  // Statics
>  FilePath ScopedChromeFrameRegistrar::GetChromeFrameBuildPath() {
> @@ -112,8 +111,7 @@
>   reference_build_dir = reference_build_dir.AppendASCII("reference_build");
>   reference_build_dir = reference_build_dir.AppendASCII("chrome");
>   reference_build_dir = reference_build_dir.AppendASCII("servers");
> -  reference_build_dir = reference_build_dir.AppendASCII(
> -      kReferenceChromeFrameDllName);
> +  reference_build_dir = reference_build_dir.Append(kChromeFrameDllName);
>   return reference_build_dir;
>  }
>
>
>
>