Issue 2859016: Simplify ForceClear situations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2859016: Simplify ForceClear situations (Closed)

Created:
10 years, 6 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@chromiumos-git/vboot_reference.git

Visibility:
Public.

Description

As mentioned, I discovered ForceClear doesn't really require any reboots. This change takes advantage of this fact. Note that I am still using TPM_MUST_REBOOT because if power is lost between ForceClear and resetting the deactivated flag, the TPM will *really* be disabled at the next reboot, and it's nice to fix this problem automatically.

Patch Set 1 #

Patch Set 2 : fix dev mode forceclear #

Patch Set 3 : fix compilation errors #

Patch Set 4 : Remove blank line #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -29 lines)			Patch
	M	firmware/lib/rollback_index.c	View	1 2 3	10 chunks	+37 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

10 years, 6 months ago (2010-06-22 00:40:12 UTC) #4

Well that was fast.  I barely got on the bus :-)

On Mon, Jun 21, 2010 at 5:31 PM,  <rspangler@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/2859016/show
>

Expand Messages | Collapse Messages