Issue 2859012: Mac: Fix duplicate definition of two symbols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2859012: Mac: Fix duplicate definition of two symbols. (Closed)

Created:
10 years, 6 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, stuartmorgan

CC:
chromium-reviews

Visibility:
Public.

Description

Mac: Fix duplicate definition of two symbols. ar -tv ../clang/sym/Release/libbrowser.a | grep login_database shows that both login_database_mac.cc and login_database_posix.cc end up being included in the build. That seems wrong. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50400

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages