Issue 2858035: Modify NPAPI::PluginList::GetPluginInfo() to return true also for disabled plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2858035: Modify NPAPI::PluginList::GetPluginInfo() to return true also for disabled plugins. (Closed)

Created:
10 years, 5 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, dpranke+watch_chromium.org, ben+cc_chromium.org, jam, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Modify NPAPI::PluginList::GetPluginInfo() to return true also for disabled plugins. GetPluginInfo() now returns true if the plugin is found, whether it's enabled or not. To find out whether the plugin is enabled, check the enabled flag in the WebPluginInfo struct output parameter. This enables getting information about disabled plugins. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51254

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -13 lines)			Patch
M	chrome/browser/plugin_service.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/buffered_resource_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/plugin_list.h	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	webkit/glue/plugins/plugin_list.cc	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

10 years, 5 months ago (2010-06-30 13:09:40 UTC) #2

LGTM

http://codereview.chromium.org/2858035/diff/1/5
File webkit/glue/plugins/plugin_list.h (right):

http://codereview.chromium.org/2858035/diff/1/5#newcode129
webkit/glue/plugins/plugin_list.h:129: // (including disabled plugins).
nit. maybe also point out that for these plugins info.enabled is false?

Expand Messages | Collapse Messages