Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2858007: Disable failing test DefaultPluginUITest.DefaultPluginLoadTest.... (Closed)

Created:
10 years, 6 months ago by Sam Kerner (Chrome)
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable failing test DefaultPluginUITest.DefaultPluginLoadTest. BUG=46662 TBR=alokp Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/default_plugin_uitest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
When disabling tests, please at least cc someone who touched this test. Also, this disabled ...
10 years, 5 months ago (2010-07-06 13:58:29 UTC) #1
Sam Kerner (Chrome)
On 2010/07/06 13:58:29, Nico wrote: > When disabling tests, please at least cc someone who ...
10 years, 5 months ago (2010-07-06 14:14:27 UTC) #2
Nico
10 years, 5 months ago (2010-07-06 14:22:24 UTC) #3
On Tue, Jul 6, 2010 at 7:14 AM,  <skerner@chromium.org> wrote:
> Reviewers: Nico,
>
> Message:
> On 2010/07/06 13:58:29, Nico wrote:
>>
>> When disabling tests, please at least cc someone who touched this test.
>
>  I thought "TBR=alokp" would CC him.  I will explicitly add people in the
> future.  I was in touch on IRC, and I CCed alokp on the bug (46662).

If alokp is a plugin guy, then no complaints. It looked to me like he
never touched DefaultPluginLoadTest. Maybe I didn't check thoroughly
enough.

>
>> Also, this disabled test didn't get its own bug.
>
>  Okay, will give each failing test its own bug, even if the failure looks
> identical to another failing test.
>
> Sam
>
>
>
> Description:
> Disable failing test DefaultPluginUITest.DefaultPluginLoadTest.
>
> BUG=46662
> TBR=alokp
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49945
>
> Please review this at http://codereview.chromium.org/2858007/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/default_plugin_uitest.cc
>
>
> Index: chrome/browser/default_plugin_uitest.cc
> ===================================================================
> --- chrome/browser/default_plugin_uitest.cc     (revision 49923)
> +++ chrome/browser/default_plugin_uitest.cc     (working copy)
> @@ -16,7 +16,8 @@
>   }
>  };
>
> -TEST_F(DefaultPluginUITest, DefaultPluginLoadTest) {
> +// Failing consistently: crbug/46662
> +TEST_F(DefaultPluginUITest, DISABLED_DefaultPluginLoadTest) {
>   // Open page with default plugin.
>   FilePath test_file(test_data_directory_);
>   test_file = test_file.AppendASCII("default_plugin.html");
>
>
>

Powered by Google App Engine
This is Rietveld 408576698