Make scm.py work around even more with bad interaction better svn client and google code.

Make scm.py work around even more with bad interaction better svn client and google code.

The novel addition here is to not convert a checkout into an update when no
files were checked out. Also delete the directory to increase the chances of
success.

TEST=wait for google code to fail again
BUG=32783
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49788

[M-A Ruel, 2010-06-15 13:56:04]

I don't have a good way to test this code so please take a look in case I missed
something obvious. I tried to comment it a lot to make the control flow clear.

[TVL, 2010-06-15 14:02:58]

http://codereview.chromium.org/2858003/diff/1/2
File scm.py (right):

http://codereview.chromium.org/2858003/diff/1/2#newcode461
scm.py:461: if os.path.isdir(args[2]):
do you need to do something with in_directory since it could be relative to
there?

http://codereview.chromium.org/2858003/diff/1/2#newcode465
scm.py:465: # No know svn error was found, bail out.
known?

http://codereview.chromium.org/2858003/diff/1/2#newcode481
scm.py:481: # No know svn error was found, bail out.
known?

[M-A Ruel, 2010-06-15 14:05:26]

http://codereview.chromium.org/2858003/diff/1/2
File scm.py (right):

http://codereview.chromium.org/2858003/diff/1/2#newcode461
scm.py:461: if os.path.isdir(args[2]):
On 2010/06/15 14:02:58, TVL wrote:
> do you need to do something with in_directory since it could be relative to
> there?

While hacking, I know that args[2] is always an absolute path... oh well. So
naively concatenating with in_directory would fail.