Issue 2858001: Changing mediaplayer to have a div blocker, so the context menus are not avai...

Issue 2858001: Changing mediaplayer to have a div blocker, so the context menus are not avai... (Closed)

Created:
10 years, 6 months ago by dhg

Modified:
9 years, 7 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Changing mediaplayer to have a div blocker, so the context menus are not available. BUG=chromium-os:3834 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50009

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/resources/mediaplayer.html	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

xiyuan

emm... shouldn't you hook up something like oncontextmenu to make it work?

10 years, 6 months ago (2010-06-15 04:42:31 UTC) #2

dhg

it does work as written On 2010/06/15 04:42:31, xiyuan wrote: > emm... shouldn't you hook ...

10 years, 6 months ago (2010-06-15 16:09:13 UTC) #3

xiyuan

LGTM Per our discussion, this CL disables context menu for video tag and shows up ...

10 years, 6 months ago (2010-06-15 16:18:59 UTC) #4

arv (Not doing code reviews)

Yeah, this is wrong. Use contextmenu and check the target instead. erik On Tue, Jun ...

10 years, 6 months ago (2010-06-15 17:36:54 UTC) #5

dhg

doesn't seem to work on the video element. On Tue, Jun 15, 2010 at 10:36 ...

10 years, 6 months ago (2010-06-15 17:49:13 UTC) #6

arv (Not doing code reviews)

10 years, 6 months ago (2010-06-15 19:06:52 UTC) #7

Sounds like a bug. Can you file it?

erik



On Tue, Jun 15, 2010 at 17:49, David Garcia <dhg@chromium.org> wrote:
> doesn't seem to work on the video element.
>
> On Tue, Jun 15, 2010 at 10:36 AM, Erik Arvidsson <arv@chromium.org> wrote:
>> Yeah, this is wrong. Use contextmenu and check the target instead.
>>
>> erik
>>
>>
>>
>> On Tue, Jun 15, 2010 at 16:18,  <xiyuan@chromium.org> wrote:
>>> LGTM
>>>
>>> Per our discussion, this CL disables context menu for video tag and shows up
>>> normal context menu and works as expected. :)
>>>
>>> http://codereview.chromium.org/2858001/show
>>>
>>
>

Expand Messages | Collapse Messages