Issue 2857020: Added --preserve option and logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2857020: Added --preserve option and logic. (Closed)

Created:
10 years, 6 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, dgarrett

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Added --preserve option and logic. Other changes: - Added update_base_packages() method. - Fix a get_latest_image.sh problem when the image does not already exist. - Cleanup method invocations, and remove OUTPUT_IMG global variable. - Add kernel testing logic back (it was accidentally deleted in an earlier patch.) TEST=Built regular image. Updated old image to contain new packages. BUG=none Patch by: Don Garrett <dgarrett@chromium.org>; (Tweaked by me to address review feedback.)

Patch Set 1 #

Patch Set 2 : Address review comments #

Total comments: 4

Patch Set 3 : Skip depclean when we're not using --preserve #

Patch Set 4 : 80 char #

Patch Set 5 : Resolve conflicts #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -17 lines)			Patch
	M	build_image	View	1 2 3 4	9 chunks	+82 lines, -17 lines	0 comments	Download
	M	get_latest_image.sh	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

Cpl more nits, o/w LGTM if you feel confident it's been tested enough. http://codereview.chromium.org/2857020/diff/8001/9001 File ...

10 years, 6 months ago (2010-06-25 02:00:11 UTC) #2

davidjames

10 years, 6 months ago (2010-06-25 02:18:37 UTC) #3

Thanks, committed

http://codereview.chromium.org/2857020/diff/8001/9001
File build_image (right):

http://codereview.chromium.org/2857020/diff/8001/9001#newcode323
build_image:323: ${SCRIPTS_DIR}/mount_gpt_image.sh -u -r "${ROOT_FS_DIR}" -s
"${STATEFUL_FS_DIR}"
On 2010/06/25 02:00:11, sosa wrote:
> 80 char

Done.

http://codereview.chromium.org/2857020/diff/8001/9001#newcode614
build_image:614: # FIXME: only signing things for x86 right now.
On 2010/06/25 02:00:11, sosa wrote:
> Weren't you planning on taking this out?

After further investigation, I found that this code was actually accidentally
deleted in an earlier commit, so it needs to be re-added (That's why dgarrett
put it in). So I decided it would a good idea to put this code back in.

Expand Messages | Collapse Messages